Skip to content

feat(cast): add alias for cast expression#127

Merged
andrew-coleman merged 5 commits intosubstrait-io:mainfrom
giospada:feat/cast-alias
Dec 3, 2025
Merged

feat(cast): add alias for cast expression#127
andrew-coleman merged 5 commits intosubstrait-io:mainfrom
giospada:feat/cast-alias

Conversation

@giospada
Copy link
Copy Markdown
Contributor

@giospada giospada commented Dec 2, 2025 •
edited
Loading

Added alias for the cast expression builder.
Includes test coverage for cast alias functionality.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 2, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

ACTION NEEDED

Substrait follows the Conventional Commits
specification for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@giospada giospada changed the title feat(cast): add alias for cast expression feat(cast): add alias for cast expression Dec 2, 2025
@tokoko
Copy link
Copy Markdown
Contributor

tokoko commented Dec 2, 2025

hey, thanks for the PR. Can you add --target-python-version 3.10 argument to codegen-extensions command in Makefile? you won't have to add a dependency on typing_extensions that way.

@tokoko
Copy link
Copy Markdown
Contributor

tokoko commented Dec 2, 2025

btw, did you run some other linter that introduced some of these changes? Probably best to stick with make lint_fix and make format commands to avoid random formatting changes in PRs.

@giospada
Copy link
Copy Markdown
Contributor Author

giospada commented Dec 3, 2025

There is a problem, right now --target-python-version 3.10 is not specified as an argument in the codegen-extensions. Therefore the CI fails if i compile with the flag, cause it's not in the Makefile, i should have fix in an other pr #131

@andrew-coleman andrew-coleman merged commit fa12088 into substrait-io:main Dec 3, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-coleman andrew-coleman andrew-coleman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@giospada @CLAassistant @tokoko @andrew-coleman